On Monday, July 21, 2014 3:32:47 PM UTC-5, Nan Liu wrote:
>
>
> https://github.com/erwbgy/puppet-system/blob/master/manifests/packages.pp
>
>

Oh, I see.  The class declares its *own* parameter 'schedule'.  Given that 
I'm not sure offhand what the semantics of that will -- or even *should* -- 
be, I have to agree with Andy that such code is nasty.  It at least 
warrants a warning.

Specifically, it's unclear whether the class's declared 'schedule' 
parameter refers to the metaparameter (so that it's a duplicate) vs. being 
an ordinary parameter that shadows the metaparameter.  If the former, then 
it's unclear whether the default value declared there will in fact be 
effective.

Furthermore, it's unclear what schedule will or should be assigned to the 
class if it is declared without an explicit schedule, but there is a 
schedule assigned to the container in which its first-evaluated declaration 
is found.  That is:

class site::wrapper {
  include 'system::packages'
}

class { 'site::wrapper': schedule => 'myschedule' }

What a mess!

With that said, if the construct in fact has a predictable, useful behavior 
(still not clear on that) then I think Nan's request for a way to silence 
the warnings is a reasonable one.


John

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-dev/690e52ca-2e14-4594-8401-e7e55626e9ee%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to