Attended: Adrien, Josh P, Michael S, Felix New:
2919: Proposal for processing an external trusted OID yaml file - Looks good so far; needs a ticket in Jira; have asked contributor for that. - Once that is in place, looks like a candidate to pull in and add a setting for. 2915: Set accept-encoding to identity when http_compression is false - Looks fine; waiting for one spec name fix from Contributor, and pinged Josh Cooper for any comments, as he was last to mention this code change in the ticket. 2890: vendor json_pure in OSX package - Checking with Moses before merging. 2879: Clarify possible exit codes and behavior with negative exit codes on Windows - Pinging Josh Cooper for additional feedback on doc changes. Held Over: Puppet: 2649: Add slot support for portage package provider. - Duplicates GH-2779, decision is to ping both contributors to see if they can coalesce their individual PRs into a single branch. Finch commenting this week. 2683: Add more config manipulation options - Needs a JIRA issue and tests are failing - Would be a good fix to have, if contributor doesn't get back to us might be worthwhile to fixup ourselves. - Adrien asking for a Ticket so we can pull it onto community board and tackle it. 2770: Allow version and held states of a package to specified as separate properties - This is a very big and sticky issue, and might be worth promoting into the platform team because of the wide ranging ramifications - Plan is to discuss how we promote issues like this, and respond to the contributor with our next steps forward - Pending contributor response 2881: Revert compare_stream to stdlib 1.9.3 implementation - Needs JIRA issue, commit message fixups - Can we split up the Ruby specific behaviors into implementation specific files for the FileSystem abstraction? - Adrien checking again to see if @keymone has time for the implementation changes suggested. 2870 (PUP-19708) Make the puppet agent retry failed requests. - Issue in commit message references projects.puppetlabs.com ticket, actual issue is https://tickets.puppetlabs.com/browse/PUP-2526 - There are a lot of cases where HTTP retries aren't meaningful (catalog retrieval, report submission) - As a general solution this is overkill, but we can retry things like file resource retrieval. - Needs better scoping of the issue being fixed - Waiting for contributor response 2869 Allow Upstart jobs on Amazon Linux - No ticket filed - This change requires adding a custom operatingsystemrelease fact for Amazon Linux, which makes it nonfunctional by default - The operatingsystemrelease fact implementation is backwards incompatible and no PR has been filed on Facter to make this work without patching - Mark issue as failed review and assign to contributor as fixup 2866 PUP-1244 puppet4 - Switches the yum provider to use RPM version comparison instead of semantic version comparison - This might be breaking but is more correct and has been requested since Puppet 0.24, document as a breaking change in Puppet 4 - Commit messages need to be fixed up, Andy to handle - Has an error; @jantman will be looking into it this week; check back next week. 2820: (PUP-2867) Support ~ in file paths, allows to deploy to ~<user> directories - Already in discussion on puppet-dev - Waiting for contributor response 2779: (PUP-2802) add slot support for packages in portage.rb - Adrien needs to take it an review it for correctness/more intensive review - Commits need to be updated to contributing guidelines - Waiting one more week; then closing if no movement 2614: (PUP-2452) Refresh support for Package type - Looks reasonable. - There is a question from the contributor about if there needs to be something changed to use this. - The answer to the question is, "yes, having a use of this is ideal". - Adrien noted that using the :methods system for the feature is hard to control. Better is to require that the provider just explicitly declare the feature, which it already does. - Another concern came up about getting refresh events that will cause unintended reinstalls. Such a case is when a class contains a package and is the target of a notify. - This is a larger change to functionality that we need to bring up on puppet-dev to figure out how to deal with the unintended consequences of adding this functionality. - Adrien to file a ticket on finer grained refresh handling and start a thread on puppet-dev to come to a decision about how to better control refresh events. Facter 731: Display facts for aliases in *BSD - It looks like the code was written by a different contributor from the GitHub submitter, we need to work out the status of CLAs for the pull request - Code could use some refactoring, cleanup, and tests, but we can work with the contributor on that - Needs a JIRA issue - Still needs work; pending contributor response; check in next week. -- Josh Partlow jpart...@puppetlabs.com Developer, Puppet Labs Join us at PuppetConf 2014, September 20-24 in San Francisco Register by July 31st to take advantage of the Early Bird discount —save $249! -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CADxAQ5oKFp%2BUq2DNiQxcPWuf7LfW2EtN5e8Bv2fsApB9dAmVfg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
