On 08/30/2014 01:00 AM, Henrik Lindberg wrote: > API is really what we define it to be. > IMO, values should be included.
Agreed. Facter.value() is very generic and unlikely to undergo any drastic changes soon (I assume). But it really forms the heart of the API, as far as I'm concerned, and the values returned in response to certain arguments are of great import. If I take the opposite assumption (fact values are not part of the API) to its extreme, then we could take the liberties of making arbitrary changes to fact values independently of release versions. On 08/30/2014 02:59 PM, Daniele Sluijters wrote: > By now, most if not all, DSL consumers are aware of the 'correct' way > to do this, str2bool($::is_virtual). As long as str2bool() with a bool > returns that bool I see no issue with changing all the boolean facts > to be actual booleans, even in a .Z release. If you're still comparing > it as a string, too bad, we've had a better way for over 2 years now. Well, yes, but there should really be a stern warning in the release notes to that effect, so that users can audit their code for missing wrappings in their Puppet code. I don't think this should be a bugfix release, either - even though you could consider the rampant maltyping to be bugs, then those still have been introduced years ago, so the fix should be deferred to the next feature release. Best, Felix -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/54025415.3070202%40Alumni.TU-Berlin.de. For more options, visit https://groups.google.com/d/optout.
