On Wed, Sep 3, 2014 at 4:32 AM, Erik Dalén <erik.gustav.da...@gmail.com> wrote:
> It would be nice to remove the document_type from the PSON hashes for > Puppet 4. This would be a modification of the API though, so it is a > backwards incompatible change. But it is data that AFAIK the agent throws > away anyway when it receives it. > > The benefit of doing this change is that the API would look the same for > all serialisation formats, and a bunch of code for the PSON special > handling could be removed. It should be completely backwards compatible for > Puppet, but other consumers of the API might be affected. > > > Here is a example of code that adds this information to the API reply > (there's a bunch of places that does this): > > https://github.com/puppetlabs/puppet/blob/puppet-4/lib/puppet/resource/catalog.rb#L390-L403 > > And here is the code that throws away that info: > > https://github.com/puppetlabs/puppet/blob/puppet-4/lib/puppet/network/formats.rb#L157-L167 > > What do you others think about doing that change? > > I think that is pretty reasonable. The information can't be very important if puppet doesn't need it in any way. Does anyone know of any consumers of the puppet REST api that depend on this being there? > -- > Erik Dalén > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to puppet-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/puppet-dev/CAAAzDLfKczVcG3LPLhFRSJhxB1hhxu%2B6jOQDT3w0uf3vD9p04w%40mail.gmail.com > <https://groups.google.com/d/msgid/puppet-dev/CAAAzDLfKczVcG3LPLhFRSJhxB1hhxu%2B6jOQDT3w0uf3vD9p04w%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- Andrew Parker a...@puppetlabs.com Freenode: zaphod42 Twitter: @aparker42 Software Developer *Join us at PuppetConf 2014 <http://www.puppetconf.com/>, September 22-24 in San Francisco* *Register by May 30th to take advantage of the Early Adopter discount <http://links.puppetlabs.com/puppetconf-early-adopter> **—**save $349!* -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CANhgQXuHsrna0rbwiLbpkvPp7mLB1wPwb_A%3Df8aZ79mOH_y5Ow%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
