On 2014-22-11 21:25, Felix Frank wrote:
On 11/22/2014 01:22 PM, Gareth Rushgrove wrote:
Hey all

I'd love some feedback on this PR, which adds the private function to
the puppet-module-skeleton that a bunch of people use.

https://github.com/garethr/puppet-module-skeleton/pull/43

A few people commented on Twitter and it's prety much 50/50.

https://twitter.com/garethr/status/535526875477839872

And I'm on the fence too. Any thoughts?

Gareth
+1 for helping module authors help their users avoid shooting their own
feet.

That's what this is about, right?
If they are creating classes that should be visible to others, they can just remove the private declaration.

A word of warning here. In puppet 4.0.0 the word "private" is reserved since the concept of being private is going to be moved to the language. The function called "private" must therefore be renamed.

- henrik


--

Visit my Blog "Puppet on the Edge"
http://puppet-on-the-edge.blogspot.se/


--
You received this message because you are subscribed to the Google Groups "Puppet 
Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-dev/m4tlp5%24na5%241%40ger.gmane.org.
For more options, visit https://groups.google.com/d/optout.

Reply via email to