> > Since it's a reimplementation of one of the ruby puppet service, I think > what I should test is that the outcome of a given request by the clojure > code is equivalent to what the ruby part would have returned. > I think this is doable by using calling the request-handler service and > comparing the result to what the clojure service would return. >
Hi, Brice. That's an interesting idea. I think that would be a very valuable manual test to run initially. However, long-term, I expect we will be deleting that functionality from the ruby codebase, at which point this test would have to be deleted (or re-written) as well. Do the existing acceptance tests in the 'puppet' repo cover this functionality? If so, that might be sufficient coverage at this 'level' of testing. You're not adding new functionality (from a user's perspective) ... so maybe the test coverage you're hoping to get is already written in the acceptance tests. We run the entire acceptance test suite in the puppet repo against puppet server in CI: https://jenkins.puppetlabs.com/view/Puppet%20Server/view/All/job/platform_puppet-server_integration-system_full-master/ -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CAF-bMBdT3U9fYM6rv%2Bv1XxHeM1iHXwe%2BQPCQwb_eDVJF11%2BAqQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
