I like all the things you have said here. Trevor
On Tue, Jul 21, 2015 at 3:40 PM, Branan Riley <bra...@puppetlabs.com> wrote: > <This is email 2/2 inspired by PUP-4813> > > With puppet 4, we made a change to how prefetch failures are handled > by the transaction[1]. This is actually a pretty good change, as it > prevents puppet from some nasty misbehaviors. > > I still don't think it's the "correct" behavior, though. Aborting the > entire catalog because one resource type is broken doesn't seem like > the best behavior, especially when it comes to reporting[2] > > I feel like the correct behavior is something like this: > > * If an exception escapes a prefetch, mark all resources of that type > in the catalog as failed and do not try to apply them > > * Make it possible to fail resources from *within* a prefetch. This > lets a sufficiently smart prefetch handle the case when only some of > its resources are hosed (parsedfile resources with multiple targets, > for example, might be only partially unfetchable) > > If there's agreement on this I'll file the appropriate tickets. If > there are other ideas of how we should handle prefetch failures I'd > also love to hear them. > > Thanks, > Branan Riley > Puppet Labs Software Engineer > > [1] PUP-3656 > [2] See https://groups.google.com/forum/#!topic/puppet-dev/QMTJli2oabc > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to puppet-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/puppet-dev/CADWDnrmDGO%3DR__fc0YxB4ywcGAbcOnASMKBw%2BPdPusGoG_nbog%40mail.gmail.com > <https://groups.google.com/d/msgid/puppet-dev/CADWDnrmDGO%3DR__fc0YxB4ywcGAbcOnASMKBw%2BPdPusGoG_nbog%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- Trevor Vaughan Vice President, Onyx Point, Inc (410) 541-6699 -- This account not approved for unencrypted proprietary information -- -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CANs%2BFoX4ZN%2BnAsN3cES6ZPuLQwz%3DyPBoR%3DQRJXR8MOvUoU3_VA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
