Could you write up an example of what kind of code would have the conditions reversed so that we can share with community members that might be affected?
On Wed, Dec 12, 2018 at 2:48 PM Kris Bosland <[email protected]> wrote: > Forwarding this to the developer group - does anyone have any feedback on > this change? > > ---------- Forwarded message --------- > From: Kris Bosland <[email protected]> > Date: Tue, Dec 11, 2018 at 10:11 AM > Subject: Re: Changes coming in PUP-9339 > To: Michael Stahnke <[email protected]> > Cc: <[email protected]> > > > We are currently not planning to change the schema version, since this > does not include a change in schema, although there will be different > information from the same Puppet actions. > > On Tue, Dec 11, 2018 at 3:57 AM Michael Stahnke <[email protected]> > wrote: > >> Does this increment the report schema version number? If so, some of the >> open source report processors and dashboards may need to know (and thus >> should be shared on puppet-dev) >> >> On Mon, Dec 10, 2018 at 4:36 PM Kris Bosland <[email protected]> >> wrote: >> >>> TL;DR: We are adding report status events and fail status for >>> refresh-only resources. This will impact logging and the execution of >>> dependent resources. If you may be impacted, please review >>> https://github.com/puppetlabs/puppet/pull/7270. >>> >>> I am sending this broadly to be sure to have a chance to catch the >>> attention of potentially impacted groups. Because of customer requirements >>> for PE-25560, we are adding report status events for refresh-only resources >>> such as reboot or some exec events. This will add new events to every >>> report. Also, because of the way dependent resource evaluation is >>> evaluated, some events that were not skipped in the past will now be >>> skipped. As an example, this test shows an event that was not skipped, but >>> it will now be skipped, reversing the sense of the test: >>> >>> https://github.com/puppetlabs/puppet/blob/4.10.x/spec/integration/transaction_spec.rb#L238-L269 >>> >>> I have just now discovered this commit, which has some impact on the >>> skipping portion of this change: >>> >>> https://github.com/puppetlabs/puppet/commit/40b3a4f86f67fb7c84aed833c05aa242338a6b3e >>> >>> >>> -- >>> Kris Bosland >>> Sr. Software Developer >>> [email protected] >>> >>> > > -- > Kris Bosland > Sr. Software Developer > [email protected] > > > > -- > Kris Bosland > Sr. Software Developer > [email protected] > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/puppet-dev/CAHDO8jSNiKj4pFVbpGQPZdsx%3DnoxfpOQ2tpQmHXQKzy_eTzEEA%40mail.gmail.com > <https://groups.google.com/d/msgid/puppet-dev/CAHDO8jSNiKj4pFVbpGQPZdsx%3DnoxfpOQ2tpQmHXQKzy_eTzEEA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CACkW_L5zEtzLCGQKsXbDjnk7_BOjsUX2hCf02dRP2JciUnEmvQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
