Hehehe - cool bananas. Happy to merge - just one small problem. I'm guessing that syntax is how you persist rules in Ubuntu? I run Ubuntu at work now but I'm a newb:
/sbin/iptables-save > /etc/iptables.rules Using that will break fedora - so we need a facter if/then. Do you have the time to add and test something like this? persist_cmd = case Facter.value(:operatingsystem) when /(Fedora|Redhat|Centos)/ then "/sbin/service iptables save" when /(Ubuntu|Debian)/ then "/sbin/iptables-save > /etc/ iptables.rules" else nil end system(persist_cmd) We should probably take this dev discussion off-thread to not create too much mail noise. Feel free to email me or get me on xmpp/google talk (same addy as my email address). ken. On Apr 21, 9:52 pm, seph <[email protected]> wrote: > Ken <[email protected]> writes: > > What scope did you define that code in? Try it in your /etc/puppet/ > > manifests/site.pp file. > > I tried it in both the iptables module and the site.pp file. But, I like > your module more. > > >http://github.com/kbarber/puppet-iptables > > > Its a mod to the camptocamp code. It persists iptables with iptables- > > save without requiring an external exec notify. It also stores the > > resource name as a comment using iptables --comment > > This is awesome. It's just what I needed. Thanks so much for writing it. > > > It was only tested on RHEL5.x - your mileage may vary. > > I found a couple problems on my ubuntu machines. I forked it > tohttp://github.com/directionless/puppet-iptablesI think you probably > want to pull some of my patches up, I sent you a thing through github. > > seph > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group > athttp://groups.google.com/group/puppet-users?hl=en. -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-users?hl=en.
