On 19.5.2011 01:01, Trevor Vaughan wrote:
> All,
> 
> I'd love to get feedback on a module that turns R.I. Pienaar's file 
> concatenation idea into a native type.
> 
> The code is located at the Onyx Point Github: 
> https://github.com/onyxpoint/pupmod-concat
> 
> We found that using this instead of the purely puppet-based implementation we 
> saw vast improvements in speed, graph complexity, and memory usage.
> 
> We'll be getting this to the module forge soon, but I thought that I'd put it 
> out for public perusal in the mean time.
> 
> Improvements welcome!

I noticed that even with
file_delimiter => '',
All fragments had an trailing newline.

Here is a simple patch which fixes this. With this you can do a single
line out of multiple fragments.

https://github.com/mafalb/pupmod-concat/tree/t_empty_file_delimiter
I also sent a pull request to onyxpoint

-- 
Kind Regards, Markus Falb

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to