On Tue, Aug 16, 2011 at 4:00 PM, David L Ballenger
<[email protected]>wrote:

>
> On Aug 16, 2011, at 10:48 AM, Nigel Kersten wrote:
>
>
>
> On Mon, Aug 15, 2011 at 6:22 PM, David L Ballenger <
> [email protected]> wrote:
>
>> Since upgrading for Puppet 2.7.1 to 2.7.3 I have been getting the
>> following error whenever a Puppet agent runs:
>>
>> err: Failed to apply catalog: Parameter options failed: Options must be
>> provided as an array, not a comma separated list
>>
>>
> Can you generate a catalog with the older version and the newer and compare
> them?
>
> Does --debug --trace add any more info ?
>
>
> Thanks for the suggestion about --trace, I didn't see that in the puppet
> help info.
>
> With --trace on I got:
>
> /Library/Ruby/Gems/1.8/gems/puppet-2.7.3/lib/puppet/type/ssh_authorized_key.rb:95:in
> `unsafe_validate'
> ......
>
> followed by more trace info.  So it looks like I am having an issue with
> the ssh_authorized_key option parameter.   When I looked at the line
> specified in the trace I found:
>
> validate do |value|
>    raise Puppet::Error, "Options must be provided as an array, not a comma
> separated list" if value != :absent and
> value.include?(',')
>  end
>
> I think the "value.Include?(',')" is a little too "inclusive".  It is
> catching a comma within a string that is part of a "from" option for the
> ssh_authorized_key to limit the systems from which the key will allow
> connections.  For example:
>
> "from=\"a.b.com,x.y.org\""
>
> I also tried 'from="a.b.com,x.y.org"' with the same results.
>
> This was working in 2.7.1.
>
>
Ugh. I can't see an obvious test to distinguish this from a comma-separated
string. Maybe if an "=" exists as well? I wonder what other options would
pass/fail that test....

We definitely have enough for a bug report here if you wouldn't mind filing
one, and we may have to abandon whatever it was that led us to have to
implement that check.


-- 
Nigel Kersten
Product Manager, Puppet Labs

*Join us for **PuppetConf *
<http://www.bit.ly/puppetconfsig>
Sept 22/23 Portland, Oregon, USA.
*
*

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-users?hl=en.

Reply via email to