If you make this a PR it would be easier to review. The major problems I see is that you removed AIX and Gentoo support (I also like to stick it to those Gentoo users, but they might get a little upset..). You also added the 'restrict' keyword back in to restrict lines but we automatically prepend that in the template.
If you make a PR against NTP I can help you review and iterate on it there however, as I can make comments inline. :) On Thu, Nov 21, 2013 at 2:24 PM, Richard Feltstykket <[email protected]>wrote: > Hi, > > I've added preliminary support for $::osfamily=Solaris on the > puppetlabs/ntp module to the below branch on github. It works for me on > OpenIndiana Hipster. This is really my first use of github and > contributing to the puppetforge in general, so can someone tell me if I've > done anything wrong? I'm going to go snag my puppet training book and make > sure I've done the tests right, and then I'll commit those to this branch > as well. > > > https://github.com/ramassa/puppetlabs-ntp/tree/feature/master/solaris_support > > Thanks, > Richard > > -- > You received this message because you are subscribed to the Google Groups > "Puppet Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/puppet-users/c1e2389f-2881-4b59-91b0-5ee3072b26cb%40googlegroups.com > . > For more options, visit https://groups.google.com/groups/opt_out. > -- Ashley Penney [email protected] Module Engineer *Join us at PuppetConf 2014, September 23-24 in San Francisco* -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/CAC9eg%2BmUwQvgsdmngx3r%2BaF5cOBc%3DECb%2BHxH8ij_ku0%2Bj%3Ducrw%40mail.gmail.com. For more options, visit https://groups.google.com/groups/opt_out.
