On Monday, April 7, 2014 5:06:25 PM UTC-5, denmat wrote:
>
> Hi, 
>
> And further to that I also did a quick skim and found you use augeas for a 
> few resources that can probably be better executed with simpler resource 
> types (I'm looking at you yumrepo). Augeas is costly from my understanding. 
>
> Also to get a good view of where the costs are in your manifest you can 
> use the practically undocumented '--evaltrace'. It will show how long it 
> takes to apply a resource on the host. 
>
>

Excellent advice.  Also, the module is BIG.  It manages a lot of pieces, so 
to some extent it can be expected to take some time for that reason alone.  
That's especially true on the first run because the module manages a lot of 
Packages, and installing packages is comparatively expensive.

Additionally, if you are managing any very large files, or recursively 
managing and directory trees containing many files, then computing the File 
checksums may be imposing a substantial cost on you.

And following on from Pete, I have rarely seen such a consistent and 
expansive collection of coding practices that I deplore.  Specifically,

   - the ensure_resource() function should never be used.  ever.
   - the resource-like form of class declarations should generally be 
   avoided, and it should *always* be avoided when no parameters are 
   declared
   
Neither of those is likely to impose much performance penalty in 
themselves, but they do make your code harder to maintain and use.


John

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-users/afc40bdc-4785-490b-95a2-df79e7b84aff%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to