I saw one of the Puppet Labs webinars about setting up your Puppet 
development environment, and at one point it mentioned using a git hook to 
run puppet-lint before committing. We do that where I work with "puppet 
parser validate," but right now a lot of our code would not pass a 
puppet-lint run with no options.

I'm curious how many people actually are that strict about it.

Also, I have a couple of specific questions about errors that show up in 
our manifests commonly.

We get this a lot:

  WARNING: quoted boolean value found on line 39

With code like this:

    $foo=hiera('foo', 'false'),

We've given a default of false for a Hiera lookup. It doesn't seem like 
there's a way around this, it seems like it actually needs to be quoted.

One other example:

  WARNING: double quoted string containing no variables on line 57

We get this when we are doing a tidy and are globbing:

  tidy { $log_directory:
    schedule => weekly,
    backup   => false,
    type     => ctime,
    recurse  => true,
    matches  => "foo.out*",
    age      => 97d,
  }

Again, I think this is supposed to be double quoted (I found some examples 
on the Puppet Labs site that had double quotes).

I know I can pass options to disable those checks, but in both cases there 
are times we might legitimately make a mistake that would cause that error, 
and I wouldn't want to ignore those...


Rich


-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-users/c459b945-cc6d-46c7-9dff-0ae6eab814e6%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to