Thanks for this guys; sorry I hadn't seen these responses till now...

I'd gladly do a PR, but what would be the situation when its not required? 
Is it if @proxy_dest or @proxy_pass are set?

Secondly; my setup (running a jenkins box behind apache) also needs these 
directives set:

AllowEncodedSlashes NoDecode

and ProxyPass with the option nocanon:

ProxyPass / http://localhost:8080/ nocanon

Should I just add these to the same PR?



On Wednesday, September 17, 2014 1:08:30 PM UTC-4, Neil - Puppet List wrote:
>
> Set it to /dev/null ?
> On 17 Sep 2014 17:53, "Hunter Haugen" <hun...@puppetlabs.com <javascript:>> 
> wrote:
>
>> Yeah, basically `$docroot` is still a required parameter because 
>> historically it was required (apache::vhost didn't do proxy stuff) and was 
>> never updated. If you want to make a PR that makes it default to `undef` 
>> and then raises helpful errors in cases when it is needed, then that would 
>> be great :).
>>
>>
>>
>> -Hunter
>>
>> On Tue, Sep 16, 2014 at 4:49 AM, Antoine Cotten <tonio....@gmail.com 
>> <javascript:>> wrote:
>>
>>> Unfortunately you can't. This is a restriction of Apache, which requires 
>>> a docroot value for every vhost, and not of Puppet.
>>>
>>> --
>>> You received this message because you are subscribed to the Google 
>>> Groups "Puppet Users" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to puppet-users...@googlegroups.com <javascript:>.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/puppet-users/8c6a00ee-3cb6-4193-936a-6acc771142ba%40googlegroups.com
>>> .
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>  -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Puppet Users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to puppet-users...@googlegroups.com <javascript:>.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/puppet-users/CAJaQvGDqJ%2BLnPmcXcz5Uv5iFgK63RawwVo8sdTr%2BX%3DQcVguiBw%40mail.gmail.com
>>  
>> <https://groups.google.com/d/msgid/puppet-users/CAJaQvGDqJ%2BLnPmcXcz5Uv5iFgK63RawwVo8sdTr%2BX%3DQcVguiBw%40mail.gmail.com?utm_medium=email&utm_source=footer>
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to puppet-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-users/89cbbd86-cfb9-4b9d-8971-923d410d241f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to