Morning all I'm trying to add some functionality to my Puppet-Glassfish[1] module to support providing an alternative download mirror.
I've made the initial code changes in caa445631d[2], however a couple of my tests are now failing[3]. I believe the issue is due to using the '$glassfish::version' variable within my params.pp[4] file which is also exposed as class variables[5] which can then be over-ridden on calling. I've tried using both the fully qualified '$glassfish::version' variable, aswell as just the local '$version' variable, but neither seem to work. The tests are complaining that the generated '$glassfish::glassfish_download_mirror' variable doesn't include a version number: > expected that the catalogue would contain > Exec[download_glassfish-3.1.2.2.zip] with command set to "wget -q > http://download.java.net/glassfish/3.1.2.2/release/glassfish-3.1.2.2.zip -O > /tmp/glassfish-3.1.2.2.zip" but it is set to "wget -q > http://download.java.net/glassfish//release/glassfish-3.1.2.2.zip -O > /tmp/glassfish-3.1.2.2.zip" > Note the double '//' between *glassfish *and *release*. Should this pattern work? Or how should I be doing it? Cheers Gavin [1] https://github.com/fatmcgav/fatmcgav-glassfish/tree/feature/alternate_download [2] https://github.com/fatmcgav/fatmcgav-glassfish/commit/caa445631d5662d5d150785a8949d5c554595007 [3] https://travis-ci.org/fatmcgav/fatmcgav-glassfish/jobs/46712102#L1200 [4] https://github.com/fatmcgav/fatmcgav-glassfish/blob/caa445631d5662d5d150785a8949d5c554595007/manifests/params.pp#L25 [5] https://github.com/fatmcgav/fatmcgav-glassfish/blob/caa445631d5662d5d150785a8949d5c554595007/manifests/init.pp#L121 -- You received this message because you are subscribed to the Google Groups "Puppet Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-users/e02dba28-d3cc-4135-96a7-67897be61e11%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
