On Tuesday, June 16, 2015 at 12:11:15 PM UTC-5, LinuxDan wrote:
>
> It scared the beans out of me when I found this code in a manifest I am 
> tasked to update / refactor.
> Does this look as outrageously wrong to you all as it looks to me ?
>
>

No.

 

> Variable names have been edited to protect the guilty
>
> class role::one {
>   hiera_include('profile::aa')
>   hiera_include('profile::bb')
>   hiera_include('profile::cc')
> }
> ...and then in common.yaml:
>
> profile::aa :
>   - syslog
>   - ttys
>   - ...(continues)
>


This is functionally equivalent to 

class role::one {
  include 'profile::aa'
  include 'profile::bb'
  include 'profile::cc'
}

...and then in module "profile":

class profile::aa {
  include 'syslog'
  include 'ttys'
  # ...(continues)
}

I don't see why the former should be considered "wrong", and certainly not 
why you think it outrageously so.  I can't judge its technical merits very 
well out of its context and in such an abstract form, but it doesn't look 
like a big deal to me.


John

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/puppet-users/fa3714c2-bcda-414d-bb39-d9d7b837e9b9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to