grant centauri said :
> >   - always pull before working back on broth
> >  - small commit (not necessarily one commit per file change or line, but
> >   one commit per fix or new feature)
> >  - only commit working code/modifications.
> >
> 
> makes sense.
> 
> so i'd want to make my change, build the iso and test it before pushing
> commits back to broth?

In theory yes,
but in practice, personally I try to follow this:
- if I just need to add a package file that I'm 100% sure of the name ->
  no
- if I add some config related things -> I might test the config file
  (or sometimes write them even) in a Puredyne running in a virtual
machine to make sure they work fine.
- if I change broth -> yes
- if I make some non trivial hooks -> yes

There are exceptions of course. Sometimes I take some risk to save me
some time in making a new ISOs, and it pays off most of the time, but
even if I commit non fully tested things every now and then on my local
bzr branch, I *always* test the changes of all my local commits before
pushing, so that my possible mistakes do not spread to others next time
they pull.


a.
--
http://su.kuri.mu

---
[email protected]
http://identi.ca/group/puredyne
irc://irc.goto10.org/puredyne

Reply via email to