Am 31.07.25 um 17:58 schrieb Gabriel Goller: > The checkbox wasn't displayed and following errors were on the console: > > failed to query /capabilites/qemu/migration on '': [object Object] > pvemanagerlib.js:20401:25 > Uncaught (in promise) TypeError: comigratedHAResources is not iterable > checkQemuPreconditions > https://172.16.0.18:8006/pve2/js/pvemanagerlib.js?ver=9.0.0~17:20595 > > Error is an object, so we need to print it in the next line, otherwise > only [object Object] is shown. Check if comigratedHAResources is > iterable, otherwise don't iterate over it. > > Signed-off-by: Gabriel Goller <[email protected]> > --- > > Tested this quickly but no idea if it's correct. Maybe Daniel and > Christoph could have a look at it. > > www/manager6/window/Migrate.js | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js > index b5ecb9603cf1..c884fbddd1aa 100644 > --- a/www/manager6/window/Migrate.js > +++ b/www/manager6/window/Migrate.js > @@ -254,7 +254,8 @@ Ext.define('PVE.window.Migrate', { > } catch (err) { > // Only emit a warning in the case the target node does not > (yet) support the > // `capabilites/qemu/migration` endpoint and simply treat > all features as unsupported. > - console.warn(`failed to query /capabilites/qemu/migration on > '${target}': ${err}`); > + console.warn(`failed to query /capabilites/qemu/migration on > '${target}':`);
this I pushed a separate patch for: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=8cc5475193930f994db38b77b518edc74f3aac90 > + console.warn(err); > } > > me.fetchingNodeMigrateInfo = false; > @@ -447,7 +448,7 @@ Ext.define('PVE.window.Migrate', { > } > > let comigratedHAResources = > migrateStats['comigrated-ha-resources']; > - if (comigratedHAResources !== undefined) { > + if (comigratedHAResources !== undefined && typeof > comigratedHAResources[Symbol.iterator] === 'function') { This became obsolete when fixing the backend: https://git.proxmox.com/?p=pve-container.git;a=commitdiff;h=0b6b4bde49244711a0ba31b09e9ccf23ec03f03b https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=eba40484c906ad8bd2d0928f2a7f36b79a53b145 And FWIW, I then made another follow-up change to not even return that property if the CT/VM is not HA managed, and changed the name from 'comigrated-ha-resources' to 'dependent-ha-resources' for both pve-container and qemu-server + the maching pve-manager UI patch. Thanks in any case for this here, as talked offlist, it might still be nice to have a generic helper in widget-toolkit, otoh. the backend type-confusion bug would not be caught by testing with that in the first place ^^ (but also not have happened in rust ;) > for (const sid of comigratedHAResources) { > const text = Ext.String.format( > gettext( _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
