On Thu Aug 7, 2025 at 2:56 PM CEST, Fiona Ebner wrote:
> Am 06.08.25 um 3:49 PM schrieb Shannon Sterz:
>> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
>> index 994189f13..a7ee842de 100644
>> --- a/PVE/CLI/pve8to9.pm
>> +++ b/PVE/CLI/pve8to9.pm
>> @@ -1282,7 +1282,8 @@ sub check_containers_cgroup_compat {
>> last if defined($libsd);
>> }
>> if (
>> - defined($libsd) && $libsd =~
>> /libsystemd-shared-(\d+)(\.\d-\d)?(\.fc\d\d)?\.so/
>> + defined($libsd)
>> + && $libsd =~
>> /libsystemd-shared-(\d+)(?:[-.][a-zA-Z0-9]+)*\.so:?$/
>
> I guess the colon at the very end is there, because in pve-container we
> check via objdump rather than checking paths? It's already optional so
> wouldn't be a functional change, but wanted to make sure.
> Since we already use
>
> my $lxc_setup = PVE::LXC::Setup->new($conf, $rootdir);
>
> below, can't we simply call
>
> $lxc_setup->unified_cgroupv2_support()
>
> directly like we do in the prestart hook?
yep makes sense, i'll look into that, but was a bit worried about bigger
changes to this code. i send a v2 with these changes, so consider this:
Superseded-by:
https://lore.proxmox.com/pve-devel/[email protected]/T/#u
_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
