Thanks @Thomas and @Dominik for the review, I will create another patch that will align with the mobile web UI which will be a bottom sheet with the explicit update or reset button.
Also, the changes will only reflect on the existing editable options. On Wed Sep 17, 2025 at 10:41 AM CEST, Thomas Lamprecht wrote: > Am 17.09.25 um 10:06 schrieb Dominik Csapak: >> >> >> On 9/4/25 11:25 AM, Shan Shaji wrote: >>> On the options page for VMs and CTs it was easy to change the >>> configs by mistake. To avoid that, added a lock/unlock button >>> on top of the screen. The toggle buttons will only be enabled >>> if the button is clicked. >>> >>> Suggested-by: Thomas Lamprecht <[email protected]> >>> Signed-off-by: Shan Shaji <[email protected]> >> I did not apply this, as we're currently evaluating a different approach >> for the yew mobile ui. If that works out, i'd prefer to have both uis >> the same (or at least similar) approaches here > > For the record: the idea is just using bottom sheets with an explicit > "update" save button for each property, i.e. both, single value ones > and more complex property strings. > > As we do not plan to very actively extend the Apps capabilities to cover > the full option range for VMs/CTs that PVE allows and just keep the > simple options we got now I'm not really sure if syncing app and mobile > web is really something we have to do. That said, I have nothing against > using a bottom sheet there too, it's a common approach and works well > for most things, but I'm also fine with going a different route, > especially if we do not expand the availability of options and HW to > configure soon(ish) here anyway, we can still change this later should > that happen. _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
