dfsm_send_state_message_full always returns != 0, since it returns cs_error_t which starts with CS_OK at 1, with values >1 representing errors.
Signed-off-by: Fabian Grünbichler <[email protected]> --- unfortunately not that cause of Alexandre's shutdown/restart issue, but might have caused some hangs as well since we would be stuck in START_SYNC in that case.. data/src/dfsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/src/dfsm.c b/data/src/dfsm.c index 529c7f9..172d877 100644 --- a/data/src/dfsm.c +++ b/data/src/dfsm.c @@ -1190,7 +1190,7 @@ dfsm_cpg_confchg_callback( dfsm_set_mode(dfsm, DFSM_MODE_START_SYNC); if (lowest_nodeid == dfsm->nodeid) { - if (!dfsm_send_state_message_full(dfsm, DFSM_MESSAGE_SYNC_START, NULL, 0)) { + if (dfsm_send_state_message_full(dfsm, DFSM_MESSAGE_SYNC_START, NULL, 0) != CS_OK) { cfs_dom_critical(dfsm->log_domain, "failed to send SYNC_START message"); goto leave; } -- 2.20.1 _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
