On 02.02.21 14:07, Dominik Csapak wrote: > the global confid variable is only there > so we could reuse the name > > so i'd prefer we remove that > and use 'let confid' in the relevant blocks > (with var this would have failed)
+1 It's general also really good to check the variables and transform all to `let`or `const` where possible. The current code base big use of `var` stems from the pre ES6 time where neither `let` nor `const` existed. I added a section to our style guide to document that: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Variables _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
