Didn't follow this issue too closely, but what about restoring a pre-QEMU-ACPI-patch Windows VM backup in a post-QEMU-ACPI-patch world? Those would need to get pinned as well, right? Doing the pinning itself on restore shouldn't be difficult, but a good way to detect when it's needed is needed.

Am 04.03.21 um 13:52 schrieb Stefan Reiter:
...and make machine version configurable in the GUI, to allow users to return to
the default behaviour of always using the latest one.

The workaround is based on a postinst script running when upgrading the
qemu-server package, which sets the machine version of all effected Windows VMs
to pc-(i440fx|q35)-5.1 to pin them to the last version still using the old ACPI
table layout.

Note: the postinst patch requires Fabian's #3301 series:
https://lists.proxmox.com/pipermail/pve-devel/2021-March/047175.html


pve-qemu: Stefan Reiter (2):
   add static supported machines file
   add ACPI compat patch for 5.1 and older machine types

  debian/parse-machines.pl                      |  21 ++++
  ...restore-device-paths-for-pre-5.1-vms.patch | 108 ++++++++++++++++++
  debian/patches/series                         |   1 +
  debian/rules                                  |   4 +-
  4 files changed, 133 insertions(+), 1 deletion(-)
  create mode 100755 debian/parse-machines.pl
  create mode 100644 
debian/patches/extra/0009-i386-acpi-restore-device-paths-for-pre-5.1-vms.patch

qemu-server: Stefan Reiter (2):
   api: add Machine module to query machine types
   add postinst with Windows device incompatibility workaround

  PVE/API2/Qemu/Machine.pm | 49 +++++++++++++++++++++
  PVE/API2/Qemu/Makefile   |  2 +-
  debian/postinst          | 95 ++++++++++++++++++++++++++++++++++++++++
  3 files changed, 145 insertions(+), 1 deletion(-)
  create mode 100644 PVE/API2/Qemu/Machine.pm
  create mode 100755 debian/postinst

manager: Stefan Reiter (3):
   api: register Qemu::Machine call
   ui: create MachineEdit window
   ui: MachineEdit: add option for machine version pinning

  PVE/API2/Nodes.pm                 |   6 ++
  www/manager6/Makefile             |   1 +
  www/manager6/qemu/HardwareView.js |  16 +----
  www/manager6/qemu/MachineEdit.js  | 107 ++++++++++++++++++++++++++++++
  4 files changed, 115 insertions(+), 15 deletions(-)
  create mode 100644 www/manager6/qemu/MachineEdit.js



_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to