Implements the necessary API for allowing single file restore via the PVE web GUI.
This requires some adaptations of the HTTP server, to allow data streaming without buffering - otherwise bigger restores would a) use up too much memory b) get slowed down by the pvedaemon->pveproxy->client return path. Instead, we transfer the data via a temporary FIFO. Known issues/further work: * restore VMs are not shown or stopped, they always run until timeout. Ideas would be to stop them when a user closes the restore window (but what if another user/tab/... is using the VM too?), or start a worker task for them (how to detect new VMs? parse proxmox-file-restore status before and after command?). Thoughts appreciated :) * restarting the daemon or proxy marks the worker as failed and correctly stops it, but the browser says the download is OK - just with not enough data. Not the best experience, but unsure on how to fix this. Chunked encoding maybe, and terminate with an invalid chunk in case of error/abort? * downloading an entire container archive (clicking on the root) doesn't currently work. I'll fix that in proxmox-file-restore. Not required, but looks better with: https://lists.proxmox.com/pipermail/pbs-devel/2021-April/002595.html common: Stefan Reiter (5): JSONSchema: don't cycle-check 'download' responses PBSClient: allow running other binaries PBSClient: add file_restore_list command PBSClient: allow different command execution callback PBSClient: add file_restore_extract function src/PVE/JSONSchema.pm | 5 +- src/PVE/PBSClient.pm | 107 +++++++++++++++++++++++++++++++++++------- 2 files changed, 94 insertions(+), 18 deletions(-) http-server: Stefan Reiter (3): allow 'download' to be passed from API handler support streaming data form fh to client allow stream download from path and over pvedaemon-proxy PVE/APIServer/AnyEvent.pm | 142 +++++++++++++++++++++++++++++++++++--- 1 file changed, 133 insertions(+), 9 deletions(-) storage: Stefan Reiter (1): add FileRestore API for PBS PVE/API2/Storage/FileRestore.pm | 163 ++++++++++++++++++++++++++++++++ PVE/API2/Storage/Makefile | 2 +- PVE/API2/Storage/Status.pm | 6 ++ 3 files changed, 170 insertions(+), 1 deletion(-) create mode 100644 PVE/API2/Storage/FileRestore.pm manager: Stefan Reiter (1): backupview: add file restore button www/manager6/grid/BackupView.js | 23 +++++++++++++++++++++++ www/manager6/storage/BackupView.js | 19 +++++++++++++++++++ 2 files changed, 42 insertions(+) -- 2.20.1 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
