On 09.06.21 15:54, Aaron Lauterer wrote:
> https://github.com/zfsonlinux/zfs/issues/8541 is solved and part of
> openzfs 2.0 with [0]. Since we ship only ZFS 2.0 with PVE 7 we should be
> okay to remove our workaround
>
> [0]
> https://github.com/openzfs/zfs/commit/47c9299fcc9e5fb91d0b1636bfacc03bd3e98439
>
> This reverts commit cdef3abb25984c369571626b38f97f92a0a2fd15.
> ---
> PVE/Storage/ZFSPoolPlugin.pm | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/PVE/Storage/ZFSPoolPlugin.pm b/PVE/Storage/ZFSPoolPlugin.pm
> index 2e2abe3..f719f42 100644
> --- a/PVE/Storage/ZFSPoolPlugin.pm
> +++ b/PVE/Storage/ZFSPoolPlugin.pm
> @@ -313,12 +313,7 @@ sub zfs_get_pool_stats {
>
> sub zfs_create_zvol {
> my ($class, $scfg, $zvol, $size) = @_;
> -
> - # always align size to 1M as workaround until
> - # https://github.com/zfsonlinux/zfs/issues/8541 is solved
> - my $padding = (1024 - $size % 1024) % 1024;
> - $size = $size + $padding;
> -
> +
above + line introduces a trailing whitespace error, please avoid that.
Can you please resend with that fixed and Fabi's T-b tag added?
> my $cmd = ['create'];
>
> push @$cmd, '-s' if $scfg->{sparse};
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
