[pve-devel] [PATCH qemu-server 2/2] migrate: enforce that image content type is available

[Fabian Ebner]

and use it for the vdisk_list call too. This avoids scanning (and picking up
volumes from!) storages that are not even configured to hold images.

Previously, the content type was only enforced when a storage map was present.

Also serves a bit as a preparation to enforce content type on guest startup,
because now migration failure happens early and not only when trying to start
the guest on the remote node.

Signed-off-by: Fabian Ebner <f.eb...@proxmox.com>
---
 PVE/QemuMigrate.pm | 25 ++++++++++++++++---------
 PVE/QemuServer.pm  |  3 +++
 2 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index 2576196..5f37890 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -341,7 +341,14 @@ sub prepare {
        my $targetsid = 
PVE::QemuServer::map_storage($self->{opts}->{storagemap}, $sid);
 
        my $scfg = PVE::Storage::storage_check_enabled($self->{storecfg}, $sid);
-       PVE::Storage::storage_check_enabled($self->{storecfg}, $targetsid, 
$self->{node});
+       my $target_scfg = PVE::Storage::storage_check_enabled(
+           $self->{storecfg},
+           $targetsid,
+           $self->{node},
+       );
+
+       die "content type 'images' is not available on storage '$targetsid'\n"
+           if !$target_scfg->{content}->{images};
 
        if ($scfg->{shared}) {
            # PVE::Storage::activate_storage checks this for non-shared storages
@@ -396,20 +403,20 @@ sub scan_local_volumes {
            next if !PVE::Storage::storage_check_enabled($storecfg, $storeid, 
undef, 1);
 
            # get list from PVE::Storage (for unused volumes)
-           my $dl = PVE::Storage::vdisk_list($storecfg, $storeid, $vmid);
+           my $dl = PVE::Storage::vdisk_list($storecfg, $storeid, $vmid, 
undef, 'images');
 
            next if @{$dl->{$storeid}} == 0;
 
            my $targetsid = 
PVE::QemuServer::map_storage($self->{opts}->{storagemap}, $storeid);
            # check if storage is available on target node
-           PVE::Storage::storage_check_enabled($storecfg, $targetsid, 
$self->{node});
+           my $target_scfg = PVE::Storage::storage_check_enabled(
+               $storecfg,
+               $targetsid,
+               $self->{node},
+           );
 
-           # grandfather in existing mismatches
-           if ($targetsid ne $storeid) {
-               my $target_scfg = PVE::Storage::storage_config($storecfg, 
$targetsid);
-               die "content type 'images' is not available on storage 
'$targetsid'\n"
-                   if !$target_scfg->{content}->{images};
-           }
+           die "content type 'images' is not available on storage 
'$targetsid'\n"
+               if !$target_scfg->{content}->{images};
 
            my $bwlimit = PVE::Storage::get_bandwidth_limit(
                'migration',
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index bd00af3..804cf79 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2458,6 +2458,9 @@ sub check_storage_availability {
        # check if storage is available on both nodes
        my $scfg = PVE::Storage::storage_check_enabled($storecfg, $sid);
        PVE::Storage::storage_check_enabled($storecfg, $sid, $node);
+
+       die "content type 'images' is not available on storage '$sid'\n"
+           if !$scfg->{content}->{images};
    });
 }
 
-- 
2.30.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel