On 05.07.21 12:57, Stoiko Ivanov wrote: > changes v1->v2: > incorporated Thomas' feedback (huge thx!) by: > * adding extra handling for Alpine and Devuan container (patch 2/2 for > pve-container) > * copying the helpers directly to pve6to7 to avoid versioned dependency > bumps > * refactoring the code in pve6to7 a bit (also returning early for > Alpine/Devuan) > * adding a 'full' parameter (would be grateful for suggestions for a better > fitting name) and only running this expensive check if it is provided > (patch 2/2 for pve-manager) > > original cover-letter for v1: > This series addresses the issue of running containers, which boot with a > systemd version which is too old (<232) to support the unified cgroup > hierarchy - This includes CentOS 7 and Ubuntu 16.04 containers. > > The patch for pve-container simply logs to syslog with level err to notify > the user. Since container start runs through our stack into systemd > (and back into our stack), I did not see a better option (grateful for > feedback if there is of course). > > One alternative might be to mount the container once in vm_start (or the > API calls), check and unmount again - but this seemed a bit expensive to do > unconditionally on every start. > > The patch for pve6to7 simply loops through all containers and checks for > the condition > > pve-container: > Stoiko Ivanov (2): > prestart-hook: detect cgroupv2 incompatible systemd version > setup: shortcut cgroupv2 support for non-systemd distros > > src/PVE/LXC/Setup.pm | 8 ++++++++ > src/PVE/LXC/Setup/Alpine.pm | 7 +++++++ > src/PVE/LXC/Setup/Base.pm | 36 ++++++++++++++++++++++++++++++++++++ > src/PVE/LXC/Setup/Devuan.pm | 7 +++++++ > src/lxc-pve-prestart-hook | 7 +++++++ > 5 files changed, 65 insertions(+) > > pve-manger: > Stoiko Ivanov (2): > pve6to7: check for containers not supporting pure cgroupv2 > pve6to7: add 'full' parameter for expensive checks > > PVE/CLI/pve6to7.pm | 138 ++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 135 insertions(+), 3 deletions(-) >
applied series, thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
