On 06/08/2021 14:57, Fabian Ebner wrote: > which can be called even when the environment is not initialized. > > Signed-off-by: Fabian Ebner <[email protected]> > --- > src/PVE/RESTEnvironment.pm | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm > index 189a6cd..4278966 100644 > --- a/src/PVE/RESTEnvironment.pm > +++ b/src/PVE/RESTEnvironment.pm > @@ -712,14 +712,20 @@ sub fork_worker { > return wantarray ? ($upid, $res) : $upid; > } > > -sub warn { > - my ($self, $message) = @_; > +sub log_warn { > + my ($message) = @_; > > chomp($message); > > print STDERR "WARN: $message\n"; > > - $self->{warning_count}++; > + $rest_env->{warning_count}++ if $rest_env; > +} > + > +sub warn { > + my ($self, $message) = @_; > + > + log_warn($message); > } > > # Abstract function >
The approach seems OK-ish in general to me, was there any off-list discussion against this or just not prioritized for review yet? _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
