FYI, it seems you sent the series to PVE devel by mistake.
On 15.09.21 15:41, Fabian Grünbichler wrote:
> like for manual pulls, but persisted in the sync job config and visible
> in the relevant GUI parts.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbich...@proxmox.com>
> ---
>
> Notes:
> GUI is read-only for now (and defaults to no filtering on creation), as
> this is
> a rather advanced feature that requires a complex GUI to be user-friendly
> (regex-freeform, type-combobox, remote group scanning + selector with
> additional freeform input).
above paragraph would belong into the commit message IMO.
>
> I did test the API manually though to see whether it works as expected,
> and
> updating the filter list by overwriting with a new one passed in as
> multiple
> parameters works as expected.
>
> if we want to make this configurable over the GUI, we probably want to
> switch
> the job edit window to a tabpanel and add a second grid tab for selecting
> the groups
we could also get away by adding it in the advanced section for now.
> diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
> index 47e65ae3..2399f11f 100644
> --- a/www/window/SyncJobEdit.js
> +++ b/www/window/SyncJobEdit.js
> @@ -199,6 +199,18 @@ Ext.define('PBS.window.SyncJobEdit', {
> ],
>
> columnB: [
> + {
> + fieldLabel: gettext('Backup Groups'),
> + xtype: 'displayfield',
> + name: 'groups',
> + renderer: function(value, metadata, record) {
> + if (!value) return gettext('All');
> + return Ext.String.htmlEncode(value, metadata, record);
Ext.String.htmlEncode only takes a single parameter
https://docs.sencha.com/extjs/7.0.0/classic/Ext.String.html#method-htmlEncode
besides that you could use a arrow fn here, the following would seem quite ok
for me for
a renderer:
renderer: v => v ? Ext.String.htmlEncode(v) : gettext('All'),
> + },
> + cbind: {
> + hidden: '{isCreate}',
> + },
> + },
> {
> fieldLabel: gettext('Comment'),
> xtype: 'proxmoxtextfield',
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
