On 10.11.21 15:02, Dominik Csapak wrote: > * fixes the saving/loading of the 'prune-backups' field (oops) > * adds correct validation for id > * adds a comment field for jobs
still missing any documentation update ;) I'd move out the schedule format section from the replication chapter to an appendix (or some other, more central place), extend backups about the new scheduling stuff. also the ID is now some in-between stuff, one needs to enter it but it won't be shown in the grid anyway, so either: 1 go the full way like PBS sync/verify/... jobs and just auto-generate, less inputs or the user is normally better UX and they can express comments already in the, well new comment field. 2 hide it only for the old ones, rather too confusing 3 allow to edit it for existing jobs, would be a bit weird for the API but as we have the digest mechanism and can do (pseudo call) `PUT /.../backup/<oldid>?id=<newid>` it could work without to much confusion.. 1 would be the least commitment now, 2 is meh and 3 is more commitment now and may open a precedent for users to nag about allowing this in more places (where it may be way harder, a nuisance or plain impossible) What do you think? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
