There are cases where we directly throw a string error (particularly, when navigator.credentials.create() fails, for example when trying to register the same WA device to the same user twice), which would end up with the WA window simply not closing before.
Signed-off-by: Wolfgang Bumiller <[email protected]> --- src/window/AddWebauthn.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/window/AddWebauthn.js b/src/window/AddWebauthn.js index f4a0b10..77d0914 100644 --- a/src/window/AddWebauthn.js +++ b/src/window/AddWebauthn.js @@ -141,7 +141,12 @@ Ext.define('Proxmox.window.AddWebauthn', { params, }); } catch (response) { - let error = response.result.message; + let error = response; + if (typeof error !== "string") { + // in case it came from an api request: + error = error.result.message; + } + console.error(error); // for debugging if it's not displayable... Ext.Msg.alert(gettext('Error'), error); } -- 2.30.2 _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
