On Fri, 21 Jan 2022, 4:48 am Dominik Csapak, <[email protected]> wrote:
> 2 nits left (you could send a v3, or we can fix it up, please > write what you prefer) > > * the commit message should not have lines longer than 70 characters[0] > * and the gettext is not optimal, i'd omit the 'Set ' prefix (sorry i did > not > catch it the first time), so 'Vendor ID' instead of 'Set vendor ID' > I would recommend keeping the "set" text in, because otherwise it makes it look like you can pick which host device you want to pass through by using those fields. I think it could confuse people. Happy for you to fix the patch as needed Cheers, Nick > otherwise: > > Reviewed-by: Dominik Csapak <[email protected]> > Tested-by: Dominik Csapak <[email protected]> > > 0: > https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages > > > _______________________________________________ > pve-devel mailing list > [email protected] > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
