On 2/10/22 14:53, Aaron Lauterer wrote:
Looks good AFAICT and does what we want.
We could improve it further by adding a small validator. Otherwise the user
will only notice their error once they get the error msg from the API.
A quick way that I came up with that could potentially be done better:
diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
index 1e34ad1c..2566d1a8 100644
--- a/www/manager6/qemu/NetworkEdit.js
+++ b/www/manager6/qemu/NetworkEdit.js
@@ -184,6 +184,13 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
bind: {
disabled: '{!isVirtio}',
},
+ validator: function(value) {
+ if (value === "" || (value > 0 && value <= 65520)) {
+ return true;
+ } else {
+ return gettext("must be between 0 and 65520");
The message here should of course read 1 instead of 0...
+ }
+ },
allowBlank: true,
},
];
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
