we already have the 'mtu' option in the API, so we can just expose
that option inside the 'Advanced' menu for virtio network interfaces.

Reviewed-By: Aaron Lauterer <a.laute...@proxmox.com>
Tested-By: Aaron Lauterer <a.laute...@proxmox.com>
Tested-By: Dylan Whyte <d.wh...@proxmox.com>
Signed-off-by: Oguz Bektas <o.bek...@proxmox.com>
---
v2->v3:
* use minValue and maxValue for validating the int range (thx aaron)
* removed the superfluous whitespace lines from v2

and i've added dylan's and aaron's tags from the previous mails as well :)

 www/manager6/qemu/NetworkEdit.js | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
index b39cffdc..3db3a569 100644
--- a/www/manager6/qemu/NetworkEdit.js
+++ b/www/manager6/qemu/NetworkEdit.js
@@ -19,6 +19,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
        me.network.macaddr = values.macaddr;
        me.network.disconnect = values.disconnect;
        me.network.queues = values.queues;
+       me.network.mtu = values.mtu;
 
        if (values.rate) {
            me.network.rate = values.rate;
@@ -33,6 +34,15 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
        return params;
     },
 
+    viewModel: {
+       data: {
+           network_model: '',
+       },
+       formulas: {
+           isVirtio: (get) => get('network_model') === 'virtio',
+       },
+    },
+
     setNetwork: function(confid, data) {
        var me = this;
 
@@ -112,6 +122,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
                            'macaddr',
                            'rate',
                            'queues',
+                           'mtu',
                        ];
                        fields.forEach(function(fieldname) {
                            
me.down('field[name='+fieldname+']').setDisabled(value);
@@ -130,6 +141,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
                xtype: 'pveNetworkCardSelector',
                name: 'model',
                fieldLabel: gettext('Model'),
+               bind: '{network_model}',
                value: PVE.qemu.OSDefaults.generic.networkCard,
                allowBlank: false,
            },
@@ -161,6 +173,18 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
                value: '',
                allowBlank: true,
            },
+           {
+               xtype: 'proxmoxintegerfield',
+               name: 'mtu',
+               fieldLabel: 'MTU',
+               value: '',
+               bind: {
+                   disabled: '{!isVirtio}',
+               },
+               minValue: 1,
+               maxValue: 65520,
+               allowBlank: true,
+           },
        ];
 
        me.callParent();
-- 
2.30.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to