Avoid that an attempt to remove a snapshot that's actively used by
replication leads to a partially (or not) removed snapshot and locked
guest.
I decided to make the checks at the call sides, because passing the
log function and timeout to snapshot_delete felt awkward as they
would only be used for obtaining the lock.
Changes from v2:
* Also check upon manual snapshot removal, not just for vzdump.
* Add common helper.
guest-common:
Fabian Ebner (1):
guest helpers: add run_with_replication_guard
src/PVE/GuestHelpers.pm | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
container:
Fabian Ebner (2):
partially fix #3424: vzdump: cleanup: wait for active replication
fix #3424: api: snapshot delete: wait for active replication
src/PVE/API2/LXC/Snapshot.pm | 12 +++++++++++-
src/PVE/VZDump/LXC.pm | 11 +++++++++--
2 files changed, 20 insertions(+), 3 deletions(-)
qemu-server:
Fabian Ebner (1):
fix #3424: api: snapshot delete: wait for active replication
PVE/API2/Qemu.pm | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
--
2.30.2
_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
