On 17.03.22 09:18, Fabian Ebner wrote: >> Agree. So, to summarize, vzdump does the interpreting for a plain, new >> `--notes` >> CLI which it also prints (with variables already resolved) in the task log >> and >> sets that also as note for the (created) backup. >> >> The job config would get a new notes-template config that allows to add such >> a dynamically interpreted string to each backup created by this job by >> bassing >> it as --notes to vzdump. That way we avoid vzdump having two different, >> clashing, >> CLI options but keep it cleanly separated for the job definitions. > > I think it'd be better or even necessary for vzdump to do the variable > expansion, because some things are not known when we start the job, for > example guest name. It'd then be enough to add a notes-template option > for vzdump, and have the job pass it along as-is with the rest of the > vzdump-config.
I meant to convey that, the "with variables already resolved" was meant for when printed to the task log, not when passed to vzdump (worded a bit confusing though) ;-) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
