On 14.03.22 10:35, Aaron Lauterer wrote: > We already know that we are acting upon a disk / volume due to the > submenu we are in.
ok with that in general, but some proposal over conveying better what "move" and "reassign" respectively means while not getting a long label. Also, a (separate) suggestions for possible icons. > > Signed-off-by: Aaron Lauterer <[email protected]> > --- > www/manager6/lxc/Resources.js | 6 +++--- > www/manager6/qemu/HardwareView.js | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js > index 4d47679d..a456fdf2 100644 > --- a/www/manager6/lxc/Resources.js > +++ b/www/manager6/lxc/Resources.js > @@ -202,7 +202,7 @@ Ext.define('PVE.lxc.RessourceView', { > }); > > let resize_menuitem = new Ext.menu.Item({ > - text: gettext('Resize disk'), > + text: gettext('Resize'), + fa-plus icon > selModel: me.selModel, > disabled: true, > handler: run_resize, > @@ -247,7 +247,7 @@ Ext.define('PVE.lxc.RessourceView', { > }); > > let reassign_menuitem = new Ext.menu.Item({ > - text: gettext('Reassign Volume'), > + text: gettext('Reassign'), "Reassign Owner" + LXC box icon > tooltip: gettext('Reassign volume to another CT'), > handler: run_reassign, > reference: 'reassing_item', > @@ -255,7 +255,7 @@ Ext.define('PVE.lxc.RessourceView', { > }); > > let move_menuitem = new Ext.menu.Item({ > - text: gettext('Move Volume'), > + text: gettext('Move'), "Move Storage" + arrow-right icon > selModel: me.selModel, > disabled: true, > handler: run_move, > diff --git a/www/manager6/qemu/HardwareView.js > b/www/manager6/qemu/HardwareView.js > index af84fb3f..3da7499d 100644 > --- a/www/manager6/qemu/HardwareView.js > +++ b/www/manager6/qemu/HardwareView.js > @@ -443,20 +443,20 @@ Ext.define('PVE.qemu.HardwareView', { > }); > > let resize_menuitem = new Ext.menu.Item({ > - text: gettext('Resize disk'), > + text: gettext('Resize'), + fa-plus icon > selModel: sm, > disabled: true, > handler: run_resize, > }); > > let move_menuitem = new Ext.menu.Item({ > - text: gettext('Move disk'), > + text: gettext('Move'), "Move Storage" + arrow-right icon > selModel: sm, > handler: run_move, > }); > > let reassign_menuitem = new Ext.menu.Item({ > - text: gettext('Reassign Disk'), > + text: gettext('Reassign'), "Reassign Owner" + VM "display" icon > tooltip: gettext('Reassign disk to another VM'), > handler: run_reassign, > selModel: sm, _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
