On 25.03.22 09:34, Daniel Tschlatscher wrote: > The backup restore dialogue now displays size information and duration in a > format more easily understandable for humans. The output was adapated to > match the output of the backup create dialogue where possible. > Added 2 helper methods for displaying bytes and time in human readable format. > > Signed-off-by: Daniel Tschlatscher <[email protected]> > --- > > Changes to v1: Fixed the indentation (there were a few rogue tab stops) and > fixed a typo in the commit message
for such changes I'd wait out for an actual review to avoid noise, e.g., like I made on 5 minutes ago ;-P Also, this depends on the type of work, but for new functionality in repos where we use debian/patches for applying downstream work it can be worth to send out the (initial) revisions as "inner" patch, i.e., like they'd come directly from the upstream patched repo, that makes review easier. A patch-patch can then be either sent once all is ready and reviewed OK, or also done by the applier (depends on the appliers' preferences, I often don't mind doing so) _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
