Am 09.06.21 um 13:54 schrieb Alexandre Derumier:
> This allow to regenerate the config drive with 1 api call.
>
> This also avoid to delete drive volume first, and recreate it again.
>
> we can simply:
> - eject
> - regenerated the volume
> - replace it with qemu monitor
>
> Signed-off-by: Alexandre Derumier <aderum...@odiso.com>
> ---
> PVE/API2/Qemu.pm | 44 ++++++++++++++++++++++++++++++++++++++++++++
> PVE/CLI/qm.pm | 3 ++-
> PVE/QemuServer.pm | 26 ++++++++++++++++++++++++++
> 3 files changed, 72 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index 8ac3ae3..7843dcb 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -1131,6 +1131,50 @@ __PACKAGE__->register_method({
> return $res;
> }});
>
> +__PACKAGE__->register_method({
> + name => 'cloudinit_update',
> + path => '{vmid}/cloudinit',
> + method => 'PUT',
> + protected => 1,
> + proxyto => 'node',
> + description => "Regenerate and change cloudinit config drive.",
> + permissions => {
> + check => ['perm', '/vms/{vmid}', 'VM.Config.Cloudinit', any => 1],
Nit: no need for "any => 1"
> + },
> + parameters => {
> + additionalProperties => 0,
> + properties => {
> + node => get_standard_option('pve-node'),
> + vmid => get_standard_option('pve-vmid'),
> + },
> + },
> + returns => { type => 'null' },
> + code => sub {
> + my ($param) = @_;
> +
> + my $rpcenv = PVE::RPCEnvironment::get();
> +
> + my $authuser = $rpcenv->get_user();
> +
> + my $vmid = extract_param($param, 'vmid');
> +
> + my $updatefn = sub {
> +
> + my $conf = PVE::QemuConfig->load_config($vmid);
> +
> + PVE::QemuConfig->check_lock($conf);
> +
> + my $storecfg = PVE::Storage::config();
> +
> + PVE::QemuServer::vmconfig_update_cloudinit_drive($storecfg, $conf,
> $vmid);
Should be renamed if we go for the "config inside ISO"-approach, because
it doesn't change the config itself now.
> +
Style nit: too many blanks
> + };
> +
> + PVE::QemuConfig->lock_config($vmid, $updatefn);
> +
> + return;
> + }});
> +
> # POST/PUT {vmid}/config implementation
> #
> # The original API used PUT (idempotent) an we assumed that all operations
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
