On 12.04.22 12:34, Stefan Sterz wrote: > move them here from pve so we can maintain them across several > products > > Signed-off-by: Stefan Sterz <[email protected]> > --- > src/Makefile | 2 + > src/panel/NotesView.js | 129 ++++++++++++++++++++++++++++++++++++++++ > src/window/NotesEdit.js | 38 ++++++++++++ > 3 files changed, 169 insertions(+) > create mode 100644 src/panel/NotesView.js > create mode 100644 src/window/NotesEdit.js > >
applied, thanks! It seems that I have wrongly conveyed that the 1:1 + changes in a separate patch means a literal 1:1, changes that are required to avoid breakage (e.g., due to redefinition of existing source classes) should be still avoided. So it's more like "move 1:1 as closely as possible without breaking the build and/or product). Anyhow, no biggie, so I just moved the class/xtypes renames into widget-toolkit patch 1 and noted in the commit message that I did so. _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
