On 27.04.2022 12:01, Thomas Lamprecht wrote:
nit, ant I don't want to be annoying, but can you please add a empty line below, and maybe even above the series-change log for easier visibility? I'd at least appreciate that quite a bit, thx!
Sure!
I think the idea was that the current behaviour (clearing filter when sorting) is undesirable in all grids and as default, but can be overridden. Meanwhile, the collapse listener covers the cases where clearing the filter is desired and already happens.src/form/ComboGrid.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js index 33c1d75..fa1078d 100644 --- a/src/form/ComboGrid.js +++ b/src/form/ComboGrid.js @@ -12,6 +12,9 @@ Ext.define('Proxmox.form.ComboGrid', {// this value is used as default value after load()preferredValue: undefined, + clearFilterOnBlur: false,this changes the default of an ExtJS config that is used in other context though?
Depending on which you prefer, I'll send in a v2 with a/this short explanation included, otherwise I guess the best thing would be a custom child class for this functionality and use that in all the places where it definitely makes sense?
_______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
