Am 12/10/2022 um 10:57 schrieb Daniel Tschlatscher:
> This patch still applies well and works as intended.
> 
> There is one UI suggestion inline.
> 
> 
> Tested-by: Daniel Tschlatscher <d.tschlatsc...@proxmox.com>
> 

thx!
>> @@ -161,6 +187,14 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
>>              value: '',
>>              allowBlank: true,
>>          },
>> +        {
>> +            xtype: 'displayfield',
>> +            userCls: 'pmx-hint',
>> +            value: gettext("Use the special value '1' to inherit the MTU 
>> value from the underlying bridge"),
>> +            bind: {
>> +                hidden: '{!showMtuHint}',
>> +            },
>> +        },
> I think it might make a bit more sense to move this into the
> advancedColumn1 as well, as now it is displayed in the opposite column,
> which makes the UI flow kind of confusing.
> Perhaps an even better option though, would be to move the displayfield
> into an advancedColumnB, which would also remove the line width limit
> and with it the somewhat ugly line break.
> 

With Oguz not working here anymore, would you like to re-send this with that
change?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to