Am 16/11/2022 um 18:34 schrieb Leo Nunner: > The process for editing Cloud-init drives checked for inconsistent > permissions: for adding, the VM.Config.Disk permission was needed, while > the VM.Config.CDROM permission was needed to remove a drive. The regex > in drive_is_cloudinit needed to be adapted since the drive names have > different formats before/after they are actually generated. > > Due to the regex letting names fall through before, Cloud-init drives > were being checked as disks, even though they are actually treated as > CDROM drives. Due to this, it makes more sense to check for > VM.Config.CDROM instead, while also requiring VM.Config.Cloudinit, since > generating a Cloud-init drive already generates default values that are > passed to the VM. > > Signed-off-by: Leo Nunner <l.nun...@proxmox.com> > --- > PVE/API2/Qemu.pm | 6 ++++-- > PVE/QemuServer/Drive.pm | 2 +- > 2 files changed, 5 insertions(+), 3 deletions(-) > >
applied, thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
