Am 10.01.23 um 14:06 schrieb Fiona Ebner: > Am 10.01.23 um 13:44 schrieb Christoph Heiss: >> On Tue, Jan 10, 2023 at 01:34:14PM +0100, Fiona Ebner wrote: >>> One way to decide if the current behavior should be used as a fallback >>> would be to check the protected status after finishing the backup. That >>> is slightly racy though, because something else could've already changed >>> the protection between finishing and the check. >> I'd base it off the decision from above - if the `proxmox-backup-client` >> version supports setting it directly, use that, otherwise simply fall >> back. > It's not just the client, but the server that needs to support it too. > To make sure that the client/QEMU/etc. support it, we can just have > pve-manager depend on a recent enough version. For the server, there is > a /version API endpoint we can query.
For QEMU, we don't want to force specific package versions, so using package dependency is not good there. Instead, we can use the 'query-proxmox-support' QMP command to see if it's supported. That also makes the check work for already running VMs. _______________________________________________ pve-devel mailing list [email protected] https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
