Sorry, didn't see that a patch was sent for this on the 15th already: https://lists.proxmox.com/pipermail/pve-devel/2023-February/055798.html.

This patch can be ignored.

On 23-02-2023 11:14, Noel Ullreich wrote:
As is, the code will throw an `ERR : line 162 col 22: no-extra-parens -
Unnecessary parentheses around expression. (*)`. Since `data.normalized`
will be evaluated as false if it is null anyway, adding a nullish operator
`??` is not needed.

Signed-off-by: Noel Ullreich <[email protected]>
---
  src/window/DiskSmart.js | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/window/DiskSmart.js b/src/window/DiskSmart.js
index b538ea1..834f065 100644
--- a/src/window/DiskSmart.js
+++ b/src/window/DiskSmart.js
@@ -159,7 +159,7 @@ Ext.define('Proxmox.window.DiskSmart', {
            {
                name: 'real-value',
                // FIXME remove with next major release (PBS 3.0)
-               calculate: data => (data.normalized ?? false) ? data.raw : 
data.value,
+               calculate: data => data.normalized ? data.raw : data.value,
            },
            {
                name: 'real-normalized',


_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Reply via email to