The respective previous versions can be found here:
- v1: https://lists.proxmox.com/pipermail/pve-devel/2023-February/055955.html
- v2: https://lists.proxmox.com/pipermail/pve-devel/2023-March/056011.html
Note: The changes to pve-common are not included in this series
anymore, as they've already been applied.
Testing
-------
The same tests as in v1 were performed.
Changes from v2:
- properly handle cleanup and warnings as well as temp file removal
if setting a new key/cert pair fails[0]
- if given, remove PID from beginning of error message after warning,
making the error message in the UI a little prettier
- use inputpanel widget for certificate upload form before
providing fix for private key upload[1]
Changes from v1:
- properly handle OpenSSL errors[2]
- provide actually correct format changes[3]
- include trailing comma[4]
- make JavaScript code a little more concise[5]
[0] https://lists.proxmox.com/pipermail/pve-devel/2023-March/056047.html
[1] https://lists.proxmox.com/pipermail/pve-devel/2023-March/056063.html
[2] https://lists.proxmox.com/pipermail/pve-devel/2023-March/055962.html
[3] https://lists.proxmox.com/pipermail/pve-devel/2023-March/055963.html
[4] Not on mailing list unfortunately, boo!
[5] https://lists.proxmox.com/pipermail/pve-devel/2023-March/055961.html
pve-manager:
Max Carrara (3):
fix #4552: certhelpers: check if custom cert and key match on change
ui: cert upload: use inputpanel for certificate upload
ui: cert upload: fix private key field sending empty string
PVE/CertHelpers.pm | 70 ++++++++++++++++++----
www/manager6/node/Certificates.js | 99 +++++++++++++++----------------
2 files changed, 105 insertions(+), 64 deletions(-)
--
2.39.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
