Am 18/07/2023 um 14:34 schrieb Dominik Csapak: > * the backup edit window is rather tall at this point, and if we assume a > minimum > screen size of 1280x720 there is not quite enough space when you subtract > the (typical) os bar and browser window decoration, maybe a 'notification' > tab would be better (we already have some tabs there anyway)
FWIW and not that I'm against tabs here (I didn't even checked the GUI at all), I came to the conclusion that 720p *and* OS/browser bar deduction is just to small to be practical.. 768p (1366 x 768) and ~90px deduction for height and 66px for those desktops that have the bar configured on the side would be more practicable, leaving 1300 x 680 as minimum. As alternative we can say 720p but in full-screen mode, i.e., so that the whole 1280 x 720 pixels are available for the web UI, or at least say that overflow is OK with smaller sizes but we ensure for scroll overflow handler on those dialogues. Could be also maybe added at a general place in EditWindow, or InputPanel if the viewport is really small, one would need to experiment with this a bit though.. Whatever the decision then is (I'm open for opinions, but pretty much set that making all work very nicely for sizes around 1200 x 600 is going to be a PITA (or just overlooked), especially as we gain more complex features), we should then update docs and maybe check if we can augment the (Edit)Window such that it outputs a warning (or even shows an error) if in debug mode and a window is bigger than the (newly) decided size, with manual resize being excluded from that check – then we'd have a higher chance in actually enforcing such a limit. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
