tl;dr implements the result of the discussion in [0]. First, this removes the dreaded LDAP DN regex, replacing it instead with a proper schema format, which does validation using Net::LDAP::Util::canonical_dn().
Further, upon saving a LDAP realm in the UI, it tries to connect & bind using the provided credentials, providing the user with immediate feedback whether they are valid or not. The same approach is already implemented in PBS [1]. Changes was done against slapd 2.5.13+dfsg-5. [0] https://lists.proxmox.com/pipermail/pve-devel/2023-May/056839.html [1] https://git.proxmox.com/?p=proxmox-backup.git;a=commitdiff;h=5210f3b5 [1] https://lists.proxmox.com/pipermail/pbs-devel/2023-June/006237.html pve-common: Christoph Heiss (3): schema: add `ldap-dn` format for validating LDAP distinguished names test: add test cases for new 'ldap-dn' schema format ldap: handle errors explicitly everywhere instead of simply `die`ing debian/control | 2 ++ src/PVE/JSONSchema.pm | 12 +++++++++ src/PVE/LDAP.pm | 11 ++++---- test/Makefile | 9 +++++++ test/ldap_dn_format_test.pl | 54 +++++++++++++++++++++++++++++++++++++ 5 files changed, 83 insertions(+), 5 deletions(-) pve-access-control: Christoph Heiss (2): ldap: validate LDAP DNs using the `ldap-dn` schema format ldap: check bind credentials with LDAP directory directly on change src/PVE/Auth/LDAP.pm | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) -- 2.41.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
