On 8/28/23 15:07, Lukas Wagner wrote:
gettext is rather dumb and does not like multi-line strings or string
interpolation.
Reported-by: Maximiliano Sandoval <[email protected]>
Signed-off-by: Lukas Wagner <[email protected]>
---
diff --git a/src/panel/NotificationConfigView.js
b/src/panel/NotificationConfigView.js
index 6586524..7935dca 100644
--- a/src/panel/NotificationConfigView.js
+++ b/src/panel/NotificationConfigView.js
@@ -88,7 +88,7 @@ Ext.define('Proxmox.panel.NotificationEndpointView', {
Ext.Msg.confirm(
gettext("Notification Target Test"),
- gettext(`Do you want to send a test notification to
'${target}'?`),
+ Ext.String.format(gettext("Do you want to send a test notification
to '{0}'?"), target),
function(decision) {
if (decision !== "yes") {
return;
@@ -101,7 +101,7 @@ Ext.define('Proxmox.panel.NotificationEndpointView', {
success: function(response, opt) {
Ext.Msg.show({
title: gettext('Notification Target Test'),
- message: gettext(`Sent test notification to
'${target}'.`),
+ message: Ext.String.format(gettext("Sent test
notification to '{0}'."), target),
buttons: Ext.Msg.OK,
icon: Ext.Msg.INFO,
});
diff --git a/src/panel/SendmailEditPanel.js b/src/panel/SendmailEditPanel.js
index b814f39..ace6129 100644
--- a/src/panel/SendmailEditPanel.js
+++ b/src/panel/SendmailEditPanel.js
@@ -80,9 +80,7 @@ Ext.define('Proxmox.panel.SendmailEditPanel', {
},
autoEl: {
tag: 'div',
- 'data-qtip': gettext(
- 'Multiple recipients must be separated by spaces, commas or
semicolons',
- ),
+ 'data-qtip': gettext('Multiple recipients must be separated by
spaces, commas or semicolons'),
},
validator: function() {
return this.up('pmxSendmailEditPanel').mailValidator();
These changes will be incorporated in v2 of the SMTP endpoint patch
series, otherwise there would be conflicts when applying.
--
- Lukas
_______________________________________________
pve-devel mailing list
[email protected]
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
